Skip to content

Conversation

@jh-leong
Copy link
Member

close #2804

@netlify
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 61b47e8
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/6748566d5ab1310008749909

@netlify
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 61b47e8
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/6748566da832910008ba5ef6
😎 Deploy Preview https://deploy-preview-2805--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/pinia@2805
npm i https://pkg.pr.new/@pinia/nuxt@2805
npm i https://pkg.pr.new/@pinia/testing@2805

commit: 61b47e8

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (3269742) to head (61b47e8).
Report is 3 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #2805   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files          19       19           
  Lines        1439     1439           
  Branches      227      227           
=======================================
  Hits         1272     1272           
  Misses        166      166           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noootwo
Copy link
Contributor

noootwo commented Nov 26, 2024

@posva When is this PR scheduled to be merged?

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wanted to remove the redundancy with SS so I used UnwrapRef like Store does to correctly extract the final type.

@posva posva merged commit ea14e53 into vuejs:v2 Nov 28, 2024
7 checks passed
@jh-leong jh-leong deleted the fix/2804 branch November 28, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

mapWritableState on setup stores doesn't unwrap refs

3 participants