fix: use +esm for vueuse >= 13 #20
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for playground-vueuse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cosine7
changed the title
Member
|
I think we can have a simple if for version 14+. here. |
Member
|
Maybe even better: |
cosine7
changed the title
Contributor
Author
👍 updated |
OrbisK
requested changes
Nov 15, 2025
app/pages/index.vue
Outdated
| ] | ||
| function generateVueUseImportCDNs() { | ||
| const file = Number.parseInt(vueuseVersion.value) >= 13 ? '+esm' : 'index.mjs' |
Member
There was a problem hiding this comment.
I think we cant use parseInt here: latest, 13.0.0, 14.0.0-alpha.1
Member
There was a problem hiding this comment.
you can use semver (already installed)
OrbisK
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21 fixes #18
by fetching VueUse package.json module field on version changes.
There might be a better solution, but this makes it work for now.