You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds the new icon from #638 but now with support for adaptive icons on devices running Android 8.0 or higher. The new icon in the shape of a rounded square is used as the legacy icon to be shown on devices running older versions of Android.
The icons have been moved from the drawables directories to mipmap directories as recommended here.
This is what the new icon looks like on legacy devices:
The adaptive icon looks different depending upon the mask used by the launcher or selected by the user:
As discussed earlier, we'll need to add credits for Michael Cook in About.
I hope it is okay to have updated the readme icon as well in this same PR.
We will need to build against SDK 26 in order to support adaptive icons though we don't need to target API 26.
The build fails because it can't find @mipmap/ic_launcher as specified in the manifest, because it only looks in main/res for mipmaps. If you move the mipmap folder there, it'll works.
I would like to hear what the devs think about this. Should I move the mipmap folder or would it be a better solution to clean up the folder structure?
The reason will be displayed to describe this comment to others. Learn more.
I like it very much, that you give credits to Michael in the Readme.
I like the approach @Nuntius0 is describing. A cleanup of the folder struture w.r.t. the icons sounds good to me.
Let's go for that. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the new icon from #638 but now with support for adaptive icons on devices running Android 8.0 or higher. The new icon in the shape of a rounded square is used as the legacy icon to be shown on devices running older versions of Android.
The icons have been moved from the
drawablesdirectories tomipmapdirectories as recommended here.This is what the new icon looks like on legacy devices:
The adaptive icon looks different depending upon the mask used by the launcher or selected by the user:




As discussed earlier, we'll need to add credits for Michael Cook in About.
I hope it is okay to have updated the readme icon as well in this same PR.
We will need to build against SDK 26 in order to support adaptive icons though we don't need to target API 26.