Skip to content

Conversation

@ayys
Copy link
Contributor

@ayys ayys commented Feb 11, 2025

Add a new page under configuration for jobs, and link to it from the main page.

Also uses packageManager field in package.json to remove the hardcoded pnpm version dependency from the GH action.

@ayys ayys force-pushed the document-jobs branch 2 times, most recently from 1f84ec8 to 20164da Compare February 11, 2025 12:27
from pnpm/action-setup docs

    version

    Optional when there is a packageManager field in the package.json.

    otherwise, this field is required It supports npm versioning scheme, it could be an exact version (such as 6.24.1), or a version range (such as 6, 6.x.x, 6.24.x, ^6.24.1, *, etc.), or latest.
@ayys ayys requested a review from baalimago February 11, 2025 12:32
Copy link
Collaborator

@baalimago baalimago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor changes, but it looks great! I'll join the job specification here and create integration tests with them. So if they don't work we'll know!

Copy link
Collaborator

@baalimago baalimago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this is next-level nitpickyness

@ayys ayys enabled auto-merge February 11, 2025 13:48
auto-merge was automatically disabled February 11, 2025 13:48

Head branch was modified

@ayys ayys enabled auto-merge February 11, 2025 13:48
@ayys ayys merged commit ba79ccf into main Feb 11, 2025
1 check passed
@ayys ayys deleted the document-jobs branch February 11, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants