Open
Conversation
Contributor
artemyarulin
commented
Mar 13, 2026
artemyarulin
commented
- Lib testing fails because there is no profiler available
- Allow passing --enable-source-maps flag to workers
…and also ensure --enable-source-maps flag in worker
syrusakbary
reviewed
Mar 13, 2026
Comment on lines
59
to
+512
| @@ -505,8 +508,8 @@ module.exports = { | |||
| DefaultSerializer, | |||
| DefaultDeserializer, | |||
| deserialize, | |||
| takeCoverage: profiler.takeCoverage, | |||
| stopCoverage: profiler.stopCoverage, | |||
| takeCoverage: profiler.takeCoverage ?? noop, | |||
| stopCoverage: profiler.stopCoverage ?? noop, | |||
Member
There was a problem hiding this comment.
We can't modify files on the lib js files.
We should only do modifications on the native side (we can probably mock it on the profiler native binding)
syrusakbary
requested changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.