benchmarks: clarify startup profile capture behavior on main#64
Open
sonukapoor wants to merge 3 commits intowasmerio:mainfrom
Open
benchmarks: clarify startup profile capture behavior on main#64sonukapoor wants to merge 3 commits intowasmerio:mainfrom
sonukapoor wants to merge 3 commits intowasmerio:mainfrom
Conversation
b12a636 to
02cf71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify and harden benchmark startup-profile capture/reporting so the output is accurate on current
main.This PR updates:
benchmarks/capture-edge-startup-profile.mjsbenchmarks/README.mdChanges
1) Capture script behavior is now accurate and less brittle
Parse potential startup-profile JSON from both stdout and stderr.
Detect profile-like JSON more defensively instead of assuming a specific key shape only.
When no startup profile JSON is emitted, write a neutral, accurate reason:
binary built without EDGE_ENABLE_STARTUP_PROFILEEDGE_STARTUP_PROFILE did not emit startup profile JSON on this checkoutMarkdown output now states that profiling output was not detected for the run, rather than asserting a specific compile-time cause.
2) README wording updated to match real harness behavior
EDGE_STARTUP_PROFILE=1.EDGE_STARTUP_PROFILE=1 ./build-edge/edge -e ""-DEDGE_ENABLE_STARTUP_PROFILE=ONas a possible path, but avoid implying it is always sufficient on every checkout.Reason
A prior issue checkpoint called out that startup-profile outputs remained unavailable even after a rebuild attempt with
-DEDGE_ENABLE_STARTUP_PROFILE=ON.This PR avoids over-claiming the cause and makes artifacts/reporting accurate for diagnosis work.
Verification