Skip to content

Conversation

@maminrayej
Copy link
Contributor

Resolves #5069.

@maminrayej maminrayej mentioned this pull request Sep 6, 2024
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still storing things as a toml in memory, which is not ideal and doesn't cause the issue with PartialEq being solved. It also attaches things as always stored in toml, but we may want in the future to target other formats.

Ideally, we should have something like:

#[derive(Debug, Clone, Default)]
pub struct CommandAnnotationBuilder {
    annotations: HashMap<String, Box<dyn Serializable>>,
}

@stale
Copy link

stale bot commented Sep 11, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Sep 11, 2025
@stale
Copy link

stale bot commented Oct 11, 2025

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏚 stale Inactive issues or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make creating annotations for a command easier

3 participants