Implement dynamic linking and loading of side modules #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arshia001
force-pushed
the
feat/dl
branch
2 times, most recently
from
f8be45a to
64a00ae
Compare
syrusakbary
reviewed
Apr 29, 2025
syrusakbary
reviewed
Apr 29, 2025
theduke
reviewed
Apr 29, 2025
Arshia001
force-pushed
the
feat/dl
branch
2 times, most recently
from
54c486b to
ec414be
Compare
|
📝 Documentation updates detected! A separate PR for documentation updates has been made here: wasmerio/docs.wasmer.io#135 |
syrusakbary
reviewed
May 5, 2025
theduke
reviewed
May 5, 2025
theduke
reviewed
May 5, 2025
syrusakbary
reviewed
May 7, 2025
syrusakbary
reviewed
May 7, 2025
|
|
||
| fn is_from_store(&self, _store: &impl wasmer::AsStoreRef) -> bool { | ||
| // TODO: find correct implementation | ||
| false |
There was a problem hiding this comment.
We probably want to return true here
There was a problem hiding this comment.
That's how it's done for every one of these. I just copy-paste the existing definitions. Not sure if that function is being called at all though, or what the consequences of returning true here would be. Let sleeping dogs lie?
Co-authored-by: Christoph Herzog <[email protected]>
…he dylink0.needed subsection, add stub import functions
…functions call stub functions
|
Superceded by #5581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is in draft status as of now, there's more left to do. Creating so people can start looking at the code.