Move shadcn directories to client shared folder #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
approved these changes
Nov 13, 2025
Collaborator
infomiho
left a comment
infomiho
left a comment
There was a problem hiding this comment.
Straightforwards and the e2e tests are passing - LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Shadcn directories under
src/clientdirectory.e.g.
src/components/ui->src/client/components/uiNewly generated Shadcn components will be placed at correct locations,
but currently it's impossible to get them to generate their import paths properly because:
Shadcn itself is buggy and doesn't really respect the
components.json:[bug]: Custom utils path inside
components.jsonis being ignored shadcn-ui/ui#5544We can't create aliases that Shadcn requires to work properly because of Wasp limitations:
https://v3.shadcn.com/docs/components-json
e.g.
@/client/*": ["src/client/*"],path alias would be nice (and would make everything work)While current components work because we fixed the imports manually.
Users adding any new components will also need to do the same for their own.
Fixes #471