Draft: Allow trailing triple-slash comments in Prisma #3016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a currently-not-working PR for allowing trailing documentation comments in a node when parsing PSL:
Right now (as of #2949) we only support leading comments.
Problem
#2949 (comment)
Solution
I asked at Haskell's Matrix Room, and got the suggestion that PSL is a newline-significant language, so it is common to split the
lexeme
parser into one that consumes whitespace and another that consumes whitespace+newlines.In the end I made two
spaceConsumer
parsers, and use the non-newline version everywhere, and the yes-newline version whenever it makes sense (in between top-level structures in the Prisma file, and inside lines in{
braces}
).I kept debugging and tweaking but at some point I had to stop working on it as it is way eating into the time budget for this task.