-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add --db-image
argument to wasp-app-runner
#3183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
98e6366
feat: add --image arg to wasp start db command
cprecioso 02fbe50
refactor: address review feedback for --image arg feature
cprecioso f3e029f
refactor: use Options.Applicative for start db argument parsing
cprecioso 071dba6
refactor: address final review comments
cprecioso eef03ef
style: format code for consistency
cprecioso cd24309
Initial impl
cprecioso 85edcbb
Fix
cprecioso 2644208
Rename data member
cprecioso 7b687b9
Correct documentation
cprecioso fd11f79
Merge branch 'db-image-arg' into image-arg-for-wasp-app-runner
cprecioso 7c5ce5d
More docs
cprecioso dcdd083
Add caveat to docs
cprecioso fee47c6
Format
cprecioso b08f5b3
Typo
cprecioso 008b004
Add changelog
cprecioso 4c6ddc2
Fixes
cprecioso f96a943
Merge branch 'main' into db-image-arg
cprecioso 7e70d20
Comment
cprecioso 9189200
Docs
cprecioso 0be6c33
comment
cprecioso f01ae55
Rename
cprecioso 3786a5c
Extract
cprecioso 7b8172e
Default postgres
cprecioso 3ad3ea1
Reorder
cprecioso 4c4283c
Rename option
cprecioso de04937
Remove unneeded comments
cprecioso 8326fae
Rename
cprecioso c37184d
Dots
cprecioso 0ae96d4
Headings
cprecioso 9a77d0f
Typo
cprecioso 11f79b3
Explanation
cprecioso 579006c
Extract default value
cprecioso f882fda
link
cprecioso 658f0dc
Fixes
cprecioso 211b356
Merge branch 'db-image-arg' into image-arg-for-wasp-app-runner
cprecioso 3d8fd82
Merge branch 'db-image-arg' into image-arg-for-wasp-app-runner
cprecioso 9d09644
Merge branch 'main' into image-arg-for-wasp-app-runner
cprecioso 5724af6
Bring to top
cprecioso a301bb4
Error out if not Postgres
cprecioso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
import type { PathToApp } from "../args.js"; | ||
import type { AppName } from "../waspCli.js"; | ||
|
||
export type SetupDbFn = (options: { | ||
appName: AppName; | ||
pathToApp: PathToApp; | ||
}) => Promise<{ | ||
dbEnvVars: { [envVarName: string]: string }; | ||
}>; | ||
export type SetupDbResult = { | ||
dbEnvVars: { | ||
[envVarName: string]: string; | ||
}; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs should mention that this can't be used in dev mode too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get the impression that it can't be used on dev mode? It can.