-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Split StarterTemplates to AvailableTemplates #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| {- HLINT ignore openSaasStarterTemplate "Redundant $" -} | ||
|
|
||
| openSaasStarterTemplate :: StarterTemplate | ||
| openSaasStarterTemplate = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This previously used a simpleGhReleaseArchiveTemplate, which was just one more layer that provided little abstraction nor extra functionality, and was only used here. I removed it and now the function creates the structure directly.
| -- is a no-op, but it exists for future-proofing. And to make consecutive calls | ||
| -- to styleCode and styleText look similar. | ||
| styleText :: String -> String | ||
| styleText = id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted this here since it is used in both AvailableTemplates and StarterTemplates, and in this way is colocated with styleCode.
| - Context: they are used by used by `wasp new`, you can find reference to them in `Wasp.Cli. ... .StarterTemplates`. | ||
| - Check and merge all PRs with the label `merge-before-release`. | ||
| - In `StarterTemplates.hs` file, update git tag to new version of Wasp we are about to release (e.g. `wasp-v0.13.1-template`). | ||
| - In `AvailableTemplates.hs` file, update git tag to new version of Wasp we are about to release (e.g. `wasp-v0.13.1-template`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the Notion checklist once we merge this
e04cca1 to
afd25f0
Compare
Deploying wasp-docs-on-main with
|
| Latest commit: |
a6b2b49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://379e4511.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-split-starter-temp.wasp-docs-on-main.pages.dev |
afd25f0 to
a6b2b49
Compare
Description
As part of adding one more kind of StarterTemplate (#3338), the
StarterTemplates.hsfile was getting crowded, so I left in this file all the types and definitions, and moved the specifications of available templates to their own file.Connections
open-saasdevelopment version is out of sync withwaspdevelopment version #3073Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests:
I added unit tests for my change.(if you fixed a bug) I added a regression test for the bug I fixed.(if you added/updated a feature) I added/updated e2e tests atexamples/kitchen-sink/e2e-tests.(if you added/updated a feature) I updated the starter templates atwaspc/data/Cli/templates, as needed.📜 Documentation:
(if you added/updated a feature) I added/updated the documentation inweb/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
I updatedwaspc/ChangeLog.mdwith a user-friendly description of the change.(if you did a breaking change) I added a step to the current migration guide atweb/docs/migration-guides/.I bumped theversioninwaspc/waspc.cabalto reflect the changes I introduced.