Skip to content

Add custom keybindings + widgetBar toggle + few fixes#3134

Closed
mswiszcz wants to merge 0 commit intowavetermdev:mainfrom
mswiszcz:main
Closed

Add custom keybindings + widgetBar toggle + few fixes#3134
mswiszcz wants to merge 0 commit intowavetermdev:mainfrom
mswiszcz:main

Conversation

@mswiszcz
Copy link
Copy Markdown

@mswiszcz mswiszcz commented Mar 27, 2026

First of all - great project! I think this has potential to be the best terminal emulator on the market.

This PR includes few adjustments I wanted to add:

  • Option to toggle sidebar in the workspace - I don't use it that often so I don't want it to waste the space. It's remembering the state across sessions and workspaces
  • Option to set custom keybindings, following VSCode patterns
  • Support for Mouse-3 and Mouse-4 buttons in browser

And few fixes:

  • Fix for browser stealing keyboard shortcuts - when browser was focused, switching between waveterm tabs with CMD+Number was not possible
  • Fix for washed out colors when using some terminal tools (missing COLORTERM env variable)
  • Fix for empty space if AI button is disabled, which is sometimes rendered and sometimes not. See bug on screenshot:
Screenshot 2026-03-27 at 17 37 24

There are few adjustments to the keybindings I want to make here, so I am for now keeping this as a draft.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 27, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6edb7e13-8729-4958-b29a-e225efc93024

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawka
Copy link
Copy Markdown
Member

sawka commented Mar 27, 2026

@mswiszcz thanks for your interest in the project, but there is just no way i can merge a PR like this. please read the contributing guidelines.

for something like keybindings, which is a major feature, and creates an ongoing user-facing dependency, we'd need to have a discussion in discord at the very least.

for the other features you've added, they need to be self contained in separate PRs so they can be tested and merged independently. i'd definitely be open to merging the webview mouse changes, and the widgets sidebar hiding change if they came in as separate PRs.

@mswiszcz
Copy link
Copy Markdown
Author

mswiszcz commented Mar 27, 2026

@sawka sure I'll extract the keybindings, sibear toggle and leave this pr with only the bugfixes - I'll update the pr later and send 2 others too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants