Add custom keybindings + widgetBar toggle + few fixes#3134
Add custom keybindings + widgetBar toggle + few fixes#3134mswiszcz wants to merge 0 commit intowavetermdev:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@mswiszcz thanks for your interest in the project, but there is just no way i can merge a PR like this. please read the contributing guidelines. for something like keybindings, which is a major feature, and creates an ongoing user-facing dependency, we'd need to have a discussion in discord at the very least. for the other features you've added, they need to be self contained in separate PRs so they can be tested and merged independently. i'd definitely be open to merging the webview mouse changes, and the widgets sidebar hiding change if they came in as separate PRs. |
|
@sawka sure I'll extract the keybindings, sibear toggle and leave this pr with only the bugfixes - I'll update the pr later and send 2 others too :) |
First of all - great project! I think this has potential to be the best terminal emulator on the market.
This PR includes few adjustments I wanted to add:
And few fixes:
There are few adjustments to the keybindings I want to make here, so I am for now keeping this as a draft.