Improve temporary error handling in package building process #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a retry mechanism for various commands in the package building scripts to enhance resilience against transient failures. A new script, «run-with-retry.sh», is added to encapsulate the retry logic, which is then utilized in multiple scripts including «wazuh-dashboard.sh», «wazuh-dashboard-plugins.sh», and others. Additionally, the Dockerfile and related scripts are updated to ensure that the retry logic is consistently applied across the package building process, improving the overall reliability of the build system.
Removed hardcoded retry parameters from the scripts and replaced them with environment variables «RETRY_MAX_ATTEMPTS» and «RETRY_DELAY_SECONDS». This change allows for more flexible configuration of retry behavior during package building, enhancing error handling and making the scripts more adaptable to different environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dev-tools/build-packages/common/run-with-retry.shas a reusable helper to tolerate transient failures, configurable viaRETRY_MAX_ATTEMPTSandRETRY_DELAY_SECONDS, and now consumed bybuild-packages.sh, which copies it into Docker contexts, exports it to the environment, and uses it when invokingdocker run.dev-tools/build-packages/base/base-builder.shloads the helper installed under/usr/local/lib/wazuh/run-with-retry.shand uses it to wrap plugin installation, while the base Dockerfile exposes this helper to the image./usr/local/lib/wazuh, adjusts thedocker-compose.ymlcontext, and adapts all plugin cloning/installation/compilation scripts to invokerun_with_retryon critical git/yarn operations, includingclone-plugins.sh.Issues Resolved
closes #990
Testing the changes
Action: https://github.com/wazuh/wazuh-dashboard/actions/runs/19337918274/job/55320744476 🟢
Changelog
Check List
yarn test:jestyarn test:jest_integration