Skip to content

Refactor the page.html.twig template#1102

Closed
trubach wants to merge 1 commit into5.xfrom
refactor/page-twig-template
Closed

Refactor the page.html.twig template#1102
trubach wants to merge 1 commit into5.xfrom
refactor/page-twig-template

Conversation

@trubach
Copy link
Contributor

@trubach trubach commented Dec 19, 2025

Moved the sidebar logic for pages into the .theme file and removed the content page specific twig template. There is now just one page.html.twig template

@trubach trubach requested a review from nhjohnstone December 19, 2025 21:41
@nhjohnstone
Copy link
Contributor

nhjohnstone commented Dec 22, 2025

@trubach, for content page, when the sidebar field is set to "No Sidebar" the sidebar menu is displaying.
example is with sandbox site /academics and /giving

When there is a block on content page, and I place it in the block UI above the main content, and then move it below, the block location doesn't update

placing block on news page so when page.html.twig is being used, the block placement does update when I move the block

@trubach trubach marked this pull request as draft February 19, 2026 15:54
@trubach
Copy link
Contributor Author

trubach commented Feb 23, 2026

Abandoning this PR code - have a new approach in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants