Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

jasonandjay
Copy link
Contributor

Description

Handled the TODO items previously left in the code: add resolver cache for ENSName

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (changes that only address relatively minor typographical errors are not accepted)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [ x My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (ae99434) to head (e254ed9).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7431   +/-   ##
=======================================
  Coverage   94.54%   94.55%           
=======================================
  Files         218      218           
  Lines        8637     8645    +8     
  Branches     2364     2365    +1     
=======================================
+ Hits         8166     8174    +8     
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs
Copy link
Contributor

jdevcs commented Jan 20, 2025

Thank you for your recent pull request. We appreciate your contributions to the Web3.js library.
As you may be aware, we are in the process of sunsetting Web3.js, and as such, we will not be merging any non-critical pull requests.
Our focus during this transition will be on addressing critical issues to ensure a smooth migration for our users.
For further details regarding the sunsetting of Web3.js, please refer to the official announcement here: Web3.js Sunset Announcement

@jdevcs jdevcs closed this Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants