Update WAMP_FEATURES constant with its attribute to prevent RN to crash at first socket connection.#5
Open
BricePissard wants to merge 1 commit intowebee:masterfrom
Open
Update WAMP_FEATURES constant with its attribute to prevent RN to crash at first socket connection.#5BricePissard wants to merge 1 commit intowebee:masterfrom
BricePissard wants to merge 1 commit intowebee:masterfrom
Conversation
…sh at first socket connection.
Owner
|
@BricePissard I used wamp.js to connect to a modified wamp server, and it's ok. I think it's better to add a method to change the default WAMP_FEATURES rather than a constant. |
Author
|
@webee each time we do a yarn add ...or a react-native installwe have to manually edit the ...
// ignore now.
var WAMP_FEATURES={};// replace when/function/call
//
...by ...
//var WAMP_FEATURES={};// replace when/function/call
var WAMP_FEATURES = {caller: {},callee: {}, publisher: {},subscriber: {} };
//
...otherwise, from start, in React Native it is not possible to use this library. The version currently published in npm is not the same than the one in GitHub. (maybe need an sh command Could you please set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update WAMP_FEATURES constant with its attribute to prevent RN to crash at first socket connection.