feat(consult-transfer): consult transfer popover improvements #570
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
The End button should remain disabled when performing a switch action during a multi-party conference involving the agent flow, to match the behavior in Agent Desktop. Steps to Reproduce:
Expected Behavior: 
|
|
The End button should remain enabled when performing a switch action during a 3-party conference involving the entry-point dial number (EP_DN) flow, to match the behavior in Agent Desktop. Steps to Reproduce:
Expected Behavior: 
|
akulakum
left a comment
akulakum
left a comment
There was a problem hiding this comment.
Please test the End button behavior across Agent, Queue, External Dial Number, and Entry Point Dial Number flows for consult, three-party, and multi-party conference scenarios.
bhabalan
force-pushed
the
consult-transfer-popover-improvements
branch
from
6ba33d9 to
6aa3fa7
Compare
akulakum
left a comment
akulakum
left a comment
There was a problem hiding this comment.
LGTM. Please fix the minor comment.
| const destAgentType = (task.data.interaction as any).destAgentType; | ||
|
|
||
| return ( | ||
| destAgentType === 'EpDn' || destAgentType === 'EPDN' || destAgentType === 'EntryPoint' || destAgentType === 'EP' |
There was a problem hiding this comment.
Please consider using an enum or shared constants for destination agent types to avoid hardcoded strings and improve reusability and maintainability.
Shreyas281299
left a comment
Shreyas281299
left a comment
There was a problem hiding this comment.
Looks good. But please remove the typecasting that we did in the tests
| variant="small" | ||
| className="tooltip" | ||
| > | ||
| <p>{`Reload ${selectedCategory}`}</p> |
There was a problem hiding this comment.
| <p>{`Reload ${selectedCategory}`}</p> | |
| <Text>{`Reload ${selectedCategory}`}</Text> |
| }, | ||
| }, | ||
| }, | ||
| } as ITask; |
There was a problem hiding this comment.
Is it possible to avoid typecasting?
| }, | ||
| }, | ||
| }, | ||
| } as ITask; |
| ...mockTask.data, | ||
| interaction: undefined, | ||
| }, | ||
| } as unknown as ITask; |
There was a problem hiding this comment.
Lets try not to do this typecasting this way this test will always pass even if we change anything in the component.
3 participants
COMPLETES #< CAI-7397 >
This pull request addresses
Enhancements and UI improvements for Consult/Transfer popover behavior.
VIDCAST: https://app.vidcast.io/share/2d81de62-3406-4a15-8ff0-887b8e7e4183
Change Type
The following scenarios were tested
Tested the scenarios in the UI
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.