Skip to content

fix: note the conditions under which the request couldn't be found #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2025
Merged

fix: note the conditions under which the request couldn't be found #460

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d872218
fix: note the conditions under which the request couldn't be found
KTibow Aug 17, 2025
6b36e64
drop the listFormat
KTibow Aug 18, 2025
a9df92d
what i get for using github.dev instead of a real editor
KTibow Aug 18, 2025
8d21cfb
oh, also it's actually a set
KTibow Aug 18, 2025
a78df35
i should REALLY stop using github.dev
KTibow Aug 18, 2025
dc0831d
okay, running locally, sorry about all that, SURELY it'll work this time
KTibow Aug 18, 2025
f1e1301
no shortcuts this time. actually using yarn. if this doesn't work...
KTibow Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/ExportsFieldPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,15 @@
}

if (paths.length === 0) {
let conditions;
if (this.conditionNames.length == 1) {

Check failure on line 118 in lib/ExportsFieldPlugin.js

View workflow job for this annotation

GitHub Actions / lint 

Expected '===' and instead saw '=='

Check failure on line 118 in lib/ExportsFieldPlugin.js

View workflow job for this annotation

GitHub Actions / lint 

This `if` statement can be replaced by a ternary expression
conditions = `the condition "${this.conditionNames[0]}"`;
} else {
conditions = `the conditions ${JSON.stringify(this.conditionNames)}`;
}
return callback(
new Error(
`Package path ${remainingRequest} is not exported from package ${request.descriptionFileRoot} (see exports field in ${request.descriptionFilePath})`,
`"${remainingRequest}" is not exported under ${conditions} from package ${request.descriptionFileRoot} (see exports field in ${request.descriptionFilePath})`,
),
);
}
Expand Down
Loading