chore: upgrade eslint from v8 to v9 #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
===========================================
- Coverage 96.31% 85.09% -11.22%
===========================================
Files 3 3
Lines 190 208 +18
Branches 59 69 +10
===========================================
- Hits 183 177 -6
- Misses 6 30 +24
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snitin315
reviewed
Jul 24, 2025
src/index.js
Outdated
Comment on lines
96
to
98
| * @property {string} name - The name of the minimizer | ||
| * @property {string} input - The input content | ||
| * @property {{ implementation: MinimizerImplementation<T>, options: MinimizerOptions<T> }} minimizer - The minimizer configuration |
Member
There was a problem hiding this comment.
Suggested change
| * @property {string} name - The name of the minimizer | |
| * @property {string} input - The input content | |
| * @property {{ implementation: MinimizerImplementation<T>, options: MinimizerOptions<T> }} minimizer - The minimizer configuration | |
| * @property {string} name The name of the minimizer | |
| * @property {string} input The input content | |
| * @property {{ implementation: MinimizerImplementation<T>, options: MinimizerOptions<T> }} minimizer The minimizer configuration |
src/index.js
Outdated
Comment on lines
103
to
105
| * @property {Array<{ code: string }>} outputs - Array of output objects | ||
| * @property {Array<Warning | WarningObject | string>} warnings - Array of warnings | ||
| * @property {Array<Error | ErrorObject | string>} errors - Array of errors |
Member
There was a problem hiding this comment.
Suggested change
| * @property {Array<{ code: string }>} outputs - Array of output objects | |
| * @property {Array<Warning | WarningObject | string>} warnings - Array of warnings | |
| * @property {Array<Error | ErrorObject | string>} errors - Array of errors | |
| * @property {Array<{ code: string }>} outputs Array of output objects | |
| * @property {Array<Warning | WarningObject | string>} warnings Array of warnings | |
| * @property {Array<Error | ErrorObject | string>} errors Array of errors |
src/index.js
Outdated
Comment on lines
119
to
122
| * @property {Rule=} test - Test rule for files to process | ||
| * @property {Rule=} include - Include rule for files to process | ||
| * @property {Rule=} exclude - Exclude rule for files to process | ||
| * @property {Parallel=} parallel - Parallel processing configuration |
Member
There was a problem hiding this comment.
Suggested change
| * @property {Rule=} test - Test rule for files to process | |
| * @property {Rule=} include - Include rule for files to process | |
| * @property {Rule=} exclude - Exclude rule for files to process | |
| * @property {Parallel=} parallel - Parallel processing configuration | |
| * @property {Rule=} test Test rule for files to process | |
| * @property {Rule=} include Include rule for files to process | |
| * @property {Rule=} exclude Exclude rule for files to process | |
| * @property {Parallel=} parallel Parallel processing configuration |
src/utils.js
Outdated
| errors: result.errors | ||
| ? result.errors.map((diagnostic) => { | ||
| const error = new Error(diagnostic.message); | ||
| // eslint-disable-next-line jsdoc/no-restricted-syntax |
Member
There was a problem hiding this comment.
Avoid to use // eslint-disable-next-line jsdoc/no-restricted-syntax when any expected, just add
// eslint-disable-next-line jsdoc/no-restricted-syntax
/** @typedef {any} EXPECTED_ANY */And then use EXPECTED_ANY in place where you should have any
alexander-akait
previously approved these changes
Jul 26, 2025
Member
|
@ersachin3112 Can you look why the coverage is decreased? |
Contributor
Author
not sure, i have not added any additional code |
Member
|
@ersachin3112 We have these changes - #156 (comment), please take a look why it was changed, maybe we need more tests or uncomment something, or we now use |
alexander-akait
approved these changes
Jul 28, 2025
alexander-akait
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No