1289 knex plugin #1418
Merged
1289 knex plugin #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
webpro
reviewed
Dec 27, 2025
Member
webpro
left a comment
webpro
left a comment
There was a problem hiding this comment.
This is great! We just need to provide more clarity about things that don't go into plugins: regular AST traversal to resolve imports is done by core already.
Member
|
Thank you! You're on a streak 🔥 |
Member
|
🚀 This pull request is included in v5.79.0. See Release 5.79.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1289
Detects database drivers (pg, mysql2, sqlite3, etc.) from knexfile.js client configurations, preventing false positives when these packages are listed as dependencies but only dynamically imported by Knex.