don't push twice for the same message to avoid race conditions #150
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ x ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR changes
Wire._messagesuch that the entire binary data of a given message is pushed into the buffer at once.This is necessary as pushing twice introduces a race condition which would produce malformed message. I saw that in practice and this change has fixed it.
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
??is widely available, but I'm not sure what backwards compatibility requirements this project has.