Skip to content

Updated README #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2025
Merged

Updated README #10

merged 4 commits into from
Jan 14, 2025

Conversation

@SageCreations
Copy link
Member

@SageCreations SageCreations commented Jan 14, 2025

  • Updated README.md
  • Edited minimal.odin to infer/teach more of the usage with the library.
  • Renamed call_js.odin to call_js_from_odin.odin
  • Renamed call_odin.odin to call_odin_from_js.odin
  • Created a new logo, will create a new branch and submit a pull request there for someone to review.

@SageCreations
updated some files names for search engine, updated README to have wi…
a472410 
…ndows commands and made it more concise, and edited the minimal example to inference a little more the usuage of webui
@SageCreations
got rid of the <script> in the minimal example in the readme for more…
1af0995 
… conciseness, still in the minmal.odin file
@SageCreations
edited the order of the contents portion to match the actual order of…
094cb6a 
… the readme
@SageCreations
Merge pull request #7 from SageCreations/update_readme
1b6c656 
Update readme
@SageCreations
Copy link
Member Author

SageCreations commented Jan 14, 2025 •
edited
Loading

odin-webui_logo

webui_odin

@SageCreations
Copy link
Member Author

SageCreations commented Jan 14, 2025

builds failed due to name changes to the example files that get built. Will need to push an update to the actions file with the new names.

@AlbertShown AlbertShown merged commit 93de53a into webui-dev:main Jan 14, 2025
0 of 2 checks passed
@AlbertShown
Copy link
Member

AlbertShown commented Jan 14, 2025

Thank you for the update, and for the logo 👍

Few things:

  • Minimal HTML should be like "<html><head><script src=\"webui.js\"></script></head> Hello World ! </html>"
  • Typo in minimal.odin Hellope!

@AlbertShown
Copy link
Member

AlbertShown commented Jan 14, 2025

Will need to push an update to the actions file with the new names.

You are right

@SageCreations
Copy link
Member Author

SageCreations commented Jan 14, 2025

Should I commit that directly into main or should I submit another pull request for those changes?

@AlbertShown
Copy link
Member

AlbertShown commented Jan 14, 2025

Directly is just fine.
In general, when there is a breaking API changes then a review from other maintainers is needed, otherwise no need for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbertShown AlbertShown AlbertShown approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SageCreations @AlbertShown