Fix RepoCard star display and translations#205
Fix RepoCard star display and translations#205alichherawalla wants to merge 2 commits intomasterfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe updates address rendering logic, styling, and translation corrections. RepoCard now displays a star count of zero, with a corresponding test added. Styling for CustomCard ensures pixel units and conditional color application. Multiple spelling errors in English translation keys and messages are corrected from "unavaiable" to "unavailable". Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/components/RepoCard/index.js (1)
46-46: Good fix for handling zero stars!This change correctly handles repositories with zero stars by explicitly checking for
stargazersCount === 0in the condition. Without this check, JavaScript would evaluate 0 as falsy and incorrectly show the unavailable message.Format the condition according to prettier's rules:
- <If condition={stargazersCount || stargazersCount === 0} otherwise={<T data-testid="stargazers-unavailable" id="repo_stars_unavailable" />}> + <If + condition={stargazersCount || stargazersCount === 0} + otherwise={<T data-testid="stargazers-unavailable" id="repo_stars_unavailable" />} + >🧰 Tools
🪛 ESLint
[error] 46-46: Replace
·condition={stargazersCount·||·stargazersCount·===·0}·otherwise={<T·data-testid="stargazers-unavailable"·id="repo_stars_unavailable"·/>}with⏎········condition={stargazersCount·||·stargazersCount·===·0}⏎········otherwise={<T·data-testid="stargazers-unavailable"·id="repo_stars_unavailable"·/>}⏎······(prettier/prettier)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
app/components/RepoCard/tests/__snapshots__/index.test.js.snapis excluded by!**/*.snap
📒 Files selected for processing (5)
app/components/RepoCard/index.js(1 hunks)app/components/RepoCard/tests/index.test.js(1 hunks)app/containers/HomeContainer/index.js(1 hunks)app/translations/en.js(1 hunks)app/translations/en.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
app/components/RepoCard/index.js (1)
app/components/T/index.js (1)
T(22-28)
🪛 ESLint
app/components/RepoCard/index.js
[error] 46-46: Replace ·condition={stargazersCount·||·stargazersCount·===·0}·otherwise={<T·data-testid="stargazers-unavailable"·id="repo_stars_unavailable"·/>} with ⏎········condition={stargazersCount·||·stargazersCount·===·0}⏎········otherwise={<T·data-testid="stargazers-unavailable"·id="repo_stars_unavailable"·/>}⏎······
(prettier/prettier)
🔇 Additional comments (5)
app/translations/en.json (1)
5-5: Spelling corrections look good!Fixed the typo in the translation keys from "unavaiable" to "unavailable" which improves the quality of user-facing text.
Also applies to: 10-10
app/translations/en.js (1)
1-1: Spelling corrections consistently applied!Fixed the typo from "unavaiable" to "unavailable" in the translation strings, maintaining consistency with the JSON translation file.
app/components/RepoCard/tests/index.test.js (2)
35-43: Good test coverage for zero stars case!This test appropriately verifies that repositories with zero stars display the star count instead of the unavailable message, matching the fix in the component.
52-52: Fixed test ID spelling consistencyCorrected the test ID from 'stargazers-unavaiable' to 'stargazers-unavailable', matching the spelling fixes in the translation files.
app/containers/HomeContainer/index.js (1)
28-29: Good fix for explicit CSS unit specification.Adding the "px" unit to the maxwidth property is a critical fix for proper CSS rendering. Without explicit units, browsers may interpret numeric values inconsistently or ignore them entirely, leading to styling issues.
The change also improves code consistency since the Container component (line 41) already follows this pattern by using the "px" unit.
1 participant
Summary
Testing
yarn test(fails: package not in lockfile)Summary by CodeRabbit