Skip to content

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Nov 4, 2025

Fixes #11879.

(See WHATWG Working Mode: Changes for more details.)


/rendering.html ( diff )

@zcorpan
Copy link
Member Author

zcorpan commented Nov 4, 2025

Maybe we should fix #2486 (comment) at the same time?

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests for the rightmargin and bottommargin attributes?

Also, I think the table is a bit confusing now as the heading says "Property". Making it "Properties" would help, but perhaps it would also require tweaking the introduction of the table.

@annevk
Copy link
Member

annevk commented Nov 4, 2025

I don't think we should couple this change with the privacy change by the way. Let's first align and then contemplate a change in how this works separately.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 5, 2025

Existing tests: https://wpt.fyi/results/html/rendering/non-replaced-elements/the-page?label=experimental&label=master&aligned

The priority order was changed in #2489 but per https://issues.chromium.org/u/1/issues/41310601#comment11 it seems @josepharhar wanted to wait with making implementation changes until the cross-origin communication channel fix is done. But I can open a separate PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

leftmargin and topmargin attributes should apply to both sides

3 participants