Move setting one permitted sandboxed navigator outside noopener branch#12298
Open
MittelmanDaniel wants to merge 1 commit intowhatwg:mainfrom
Open
Move setting one permitted sandboxed navigator outside noopener branch#12298MittelmanDaniel wants to merge 1 commit intowhatwg:mainfrom
MittelmanDaniel wants to merge 1 commit intowhatwg:mainfrom
Conversation
Since whatwg#4330 made target=_blank imply noopener=true, the one permitted sandboxed navigator is never set for sandboxed iframe popups because it was inside the noopener=false (Otherwise) branch. This moves it outside both branches so it runs regardless of noopener, matching Firefox's implementation and the existing placement of the sandbox-propagates-to-auxiliary step. Fixes whatwg#12297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12297.
Summary
Since #4330 made
target="_blank"implynoopener=true, the "one permitted sandboxed navigator" is never set for sandboxed iframe popups because it lives inside thenoopener=false("Otherwise") branch of the rules for choosing a navigable.This moves the step outside both branches so it runs regardless of noopener, matching Firefox's implementation and the existing placement of the "sandbox propagates to auxiliary browsing contexts" step which is already outside both branches.
Change
Context
target="_blank"imply noopener, inadvertently putting alltarget="_blank"links on the code path that skips setting the permitted navigator/document-sequences.html ( diff )