Open
Conversation
thisisaaronland
requested changes
May 21, 2023
Member
thisisaaronland
left a comment
thisisaaronland
left a comment
There was a problem hiding this comment.
Thanks for your PR. A general-purpose "relay to an HTTP endpoint" dispatcher would be useful. I've added some comments and questions.
straup
reviewed
May 21, 2023
…gic away from Dispatcher, updated unit tests to include HTTP mock
thisisaaronland
requested changes
May 30, 2023
Member
thisisaaronland
left a comment
thisisaaronland
left a comment
There was a problem hiding this comment.
Thanks for the first round of updates and apologies for the delay in getting to them. It all looks good but I've flagged a few more "details".
thisisaaronland
approved these changes
Jun 13, 2023
thisisaaronland
requested changes
Jul 11, 2023
Member
thisisaaronland
left a comment
thisisaaronland
left a comment
There was a problem hiding this comment.
It looks like http.go and http_test.go are both still using the bespoek HTTPClient rather than a plain-vanilla http.Client{} instance?
Author
|
@thisisaaronland any suggestions on how to modify this? |
Member
|
Something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added an http forwarder dispatcher - can be configured in the config.json with http://host/test