Facepalm: correctly get campaign id from Activity's intent. #4993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
commented
Sep 27, 2024
| when (resultCode) { | ||
| Activity.RESULT_OK -> { | ||
| data?.let { intent -> | ||
| PaymentData.getFromIntent(intent)?.let { paymentData -> |
There was a problem hiding this comment.
This name of intent is shadowing the Activity's intent getter (shorthand for the function getIntent()), so when we get the campaign ID a few lines later, by calling intent.getStringExtra..., we're referencing the wrong intent!
cooltey
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the most unfortunate cases of name shadowing, there were two variables called
intent, and we were using the wrong one to get the campaign ID, resulting in a fallback to the default id.https://phabricator.wikimedia.org/T375124