Fix FromHtml rendering of ordered lists with Paragraph spans. #4994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our handling of ordered list
<ol>tags is kind of brittle already, and can lead to issues, because we programmatically insert text into anEditableinside a phase where text shouldn't really be inserted. This can cause clashes with existing Spans, especially ParagraphStyle spans.This fixes further existing issues by explicitly removing any additional
ParagraphStylespans that might be interfering with an<ol>tag. A more permanent solution will need to be devised later.https://phabricator.wikimedia.org/T375728