Skip to content

Prevent possible crash due to null RemoteConfig. #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Prevent possible crash due to null RemoteConfig. #6005

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72de54e
Prevent possible crash due to null RemoteConfig.
dbrant Oct 15, 2025
8c1c845
Update YiR remote config.
dbrant Oct 15, 2025
1f9d485
Merge branch 'main' into remoteConfigNullable
cooltey Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions app/src/main/java/org/wikipedia/settings/RemoteConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ object RemoteConfig {
RemoteConfigImpl()
}
}
return curConfig!!
return curConfig ?: RemoteConfigImpl()
}

fun updateConfig(config: RemoteConfigImpl) {
Expand All @@ -41,7 +41,11 @@ object RemoteConfig {
@Suppress("unused")
@Serializable
class RemoteConfigCommonV1 {
val yir: RemoteConfigYearInReview? = null
val yir: List<RemoteConfigYearInReview> = emptyList()

fun getYirForYear(year: Int): RemoteConfigYearInReview? {
return yir.find { it.year == year }
}
}

@Suppress("unused")
Expand Down Expand Up @@ -93,7 +97,7 @@ object RemoteConfig {
@Serializable
class TopReadPercentage(
val identifier: String = "",
val min: Int? = null,
val max: Int? = null
val min: Int = 0,
val max: Int = Int.MAX_VALUE
)
}
Loading