YiR: Geo slide #6014
Open
YiR: Geo slide #6014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooltey
reviewed
Oct 17, 2025
Comment on lines
+241
to
+244
| map.moveCamera(CameraUpdateFactory.newLatLngZoom(LatLng(latitude, longitude), zoom), object : MapLibreMap.CancelableCallback { | ||
| override fun onCancel() { } | ||
| override fun onFinish() { } | ||
| }) |
There was a problem hiding this comment.
This can be simplified: map.moveCamera(CameraUpdateFactory.newLatLngZoom(LatLng(latitude, longitude), zoom))
| private fun geoWithArticlesScreen(vararg params: Int): YearInReviewScreenData.GeoScreen { | ||
| // TODO: yir112 | ||
| private fun geoWithArticlesScreen(): YearInReviewScreenData.GeoScreen? { | ||
| if (yearInReviewModel.largestClusterCountryName.isEmpty() || yearInReviewModel.largestClusterArticles.size < 2) { |
There was a problem hiding this comment.
Can you add 2 to YearInReviewViewModel as a constant value like: MIN_CLUSTER_ARTICLE = 2
| var largestClusterLongitude = 0.0 | ||
| var largestClusterCountryName = "" | ||
| val largestClusterArticles = mutableListOf<String>() | ||
| if (pagesWithCoordinates.size > 2) { |
There was a problem hiding this comment.
Can these 2 be replaced by the same constant value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T405427