Skip to content

Clear donation history overflow menu in Activity tab #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

Clear donation history overflow menu in Activity tab #6019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
376cb6e
- adds "clear donation history" option to activity tab overflow menu
Williamrai Oct 21, 2025
beef4dd
Merge branch 'main' into activity-tab-clear-donations
cooltey Oct 21, 2025
9c1336c
Merge branch 'main' into activity-tab-clear-donations
Williamrai Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/src/main/java/org/wikipedia/activitytab/ActivityTabFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,13 @@ class ActivityTabFragment : Fragment() {
}
true
}
R.id.menu_clear_donation_history -> {
ActivityTabEvent.submit(activeInterface = "activity_tab_overflow_menu", action = "clear_donation_history_click")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, have you checked with the analyst about the event strings?

Copy link
Collaborator Author

@Williamrai Williamrai Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, confirmed with shay. Link

Prefs.donationResults = emptyList()
Prefs.activityTabModules = Prefs.activityTabModules.setModuleEnabled(ModuleType.DONATIONS, false)
viewModel.loadAll()
true
}
R.id.menu_learn_more -> {
ActivityTabEvent.submit(activeInterface = "activity_tab_overflow_menu", action = "learn_click")
UriUtil.visitInExternalBrowser(requireActivity(), getString(R.string.activity_tab_url).toUri())
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/menu/menu_activity_tab_overflow.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
android:icon="@drawable/ic_delete_white_24dp"
android:title="@string/menu_clear_all_history"
app:iconTint="?attr/secondary_color" />
<item
android:id="@+id/menu_clear_donation_history"
android:icon="@drawable/ic_delete_white_24dp"
android:title="@string/preference_title_delete_local_donation_history"
app:iconTint="?attr/secondary_color" />
<item
android:id="@+id/menu_report_feature"
android:icon="@drawable/ic_report_flag"
Expand Down
Loading