-
-
Notifications
You must be signed in to change notification settings - Fork 739
Activity Tab: add "Total edits across projects". #6024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/src/main/java/org/wikipedia/activitytab/ActivityTabFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just have one more question regarding: ActivityTabViewModel.getTotalEditsCount(), which will be used when sending events. Are we going to send the "total edits count" for the primary language only? or total edits count for "all projects"
Good question; and let's keep this as it was before: |
Got it, thanks! |
https://phabricator.wikimedia.org/T406756