Skip to content

Conversation

@dbrant
Copy link
Member

@dbrant dbrant commented Oct 21, 2025

Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have one more question regarding: ActivityTabViewModel.getTotalEditsCount(), which will be used when sending events. Are we going to send the "total edits count" for the primary language only? or total edits count for "all projects"

@dbrant
Copy link
Member Author

dbrant commented Oct 22, 2025

LGTM. Just have one more question regarding: ActivityTabViewModel.getTotalEditsCount(), which will be used when sending events. Are we going to send the "total edits count" for the primary language only? or total edits count for "all projects"

Good question; and let's keep this as it was before: ActivityTabViewModel.getTotalEditsCount() will still return the primary-wiki edit count, to remain consistent with events we've already been sending. If we need to send new (or additional) events with the "all projects" count, we can add it later.

@cooltey
Copy link
Collaborator

cooltey commented Oct 22, 2025

LGTM. Just have one more question regarding: ActivityTabViewModel.getTotalEditsCount(), which will be used when sending events. Are we going to send the "total edits count" for the primary language only? or total edits count for "all projects"

Good question; and let's keep this as it was before: ActivityTabViewModel.getTotalEditsCount() will still return the primary-wiki edit count, to remain consistent with events we've already been sending. If we need to send new (or additional) events with the "all projects" count, we can add it later.

Got it, thanks!

@cooltey cooltey merged commit b8730d2 into main Oct 22, 2025
1 check passed
@cooltey cooltey deleted the activityTabTotalEdits branch October 22, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants