YiR: wire up instrumentation #6062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hi @dbrant @Williamrai, This is ready for review, and there is one issue waiting for another PR to be resolved, but overall this is ready. |
Williamrai
reviewed
Nov 6, 2025
app/src/main/java/org/wikipedia/yearinreview/YearInReviewOnboardingScreen.kt
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/yearinreview/YearInReviewOnboardingScreen.kt
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/settings/SettingsPreferenceLoader.kt
Outdated
Show resolved
Hide resolved
| action = "impression", | ||
| slide = pages[page].slideName | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
This should be placed inside a LaunchedEffect(pagerState.currentPage) to avoid sending multiple events when the screen recomposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T405507