Introduce idea of a TimingFunction#83
Open
Jackson Taylor (jacksontaylor13) wants to merge 4 commits intomasterfrom
Open
Introduce idea of a TimingFunction#83Jackson Taylor (jacksontaylor13) wants to merge 4 commits intomasterfrom
Jackson Taylor (jacksontaylor13) wants to merge 4 commits intomasterfrom
Conversation
Given by issue #77, we introduce this idea of a TimingFunction now. This should allow any sort function to be considered a continuous or inter item function. This separates the notion that the two are related and brings TimingFunction to be an entirely new concept.
With the new `TimingFunction` protocol being added, we needed to make sure that it works properly with the example app. This will be a breaking change for some functions but we are going to submit another PR on top of this that should minimize the breaking nature of this change.
Jackson Taylor (jacksontaylor13)
requested review from
Erik LaManna (eriklamanna) and
Matt Yohe (mattyohe)
Contributor
Author
|
Still need to fix the unit tests, since the tests currently rely on |
Jackson Taylor (jacksontaylor13)
requested a review
from Ian Terrell (ianterrell)
Ian Terrell (ianterrell)
left a comment
Ian Terrell (ianterrell)
left a comment
There was a problem hiding this comment.
I only really gave it a cursory skim, but: I'm glad to see this change making it in! I think it's a good improvement in the concepts of an already great library. 👍
|
|
||
| } | ||
|
|
||
| public init(duration: TimeInterval) { |
There was a problem hiding this comment.
Rather than the default on the stored property you could consider a default value for this parameter and remove the empty init above.
|
|
||
| } | ||
|
|
||
| public init(interObjectDelay: TimeInterval) { |
There was a problem hiding this comment.
Ditto here with default parameter.
| /// - completion: a closure that is called upon the final animation completing. A `Bool` is passed into the closure letting you know if the animation has completed. **Note:** If you stop animations on the whole animating view, then `false` will be passed into the completion closure. However, if the final animation is allowed to proceed then `true` will be the value passed into the completion closure. | ||
| public func animate(withSortFunction sortFunction: SortFunction, prepare: PrepareHandler? = nil, animation: Animation, exclude: [UIView]? = nil, recursiveDepth: Int = 0, completion: CompletionHandler? = nil) { | ||
| var timedViews = sortFunction.timeOffsets(view: self.view, recursiveDepth: recursiveDepth) | ||
| public func animate(withSortFunction sortFunction: SortFunction, timingFunction: TimingFunction, prepare: PrepareHandler? = nil, animation: Animation, exclude: [UIView]? = nil, recursiveDepth: Int = 0, completion: CompletionHandler? = nil) { |
There was a problem hiding this comment.
The curse of good documentation — you need to update the parameter above.
|
|
||
| public func timeOffsets(view: UIView, recursiveDepth: Int) -> [TimedView] { | ||
| public func weights(forView view: UIView, recursiveDepth: Int) -> [WeightedView] { |
There was a problem hiding this comment.
weights(for view: UIView... is probably slightly more idiomatic naming.
|
|
||
| import Foundation | ||
|
|
||
| /// An internal struct that is used to relate a view with a time offset. This is used to determine when each view is set to animate. |
There was a problem hiding this comment.
The tiniest bit confusing to call it an "internal struct".
Add stock timing functions To make calling a timing function easier, there will now be an `enum` called `StockTimingFunction` that uses associated values to make creating a timing function super quick and easy.
Generated by 🚫 Danger |
Chris Kontalonis (ckontalonis)
removed the request for review
from Erik LaManna (eriklamanna)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given by issue #77, we introduce this idea of a TimingFunction now. This should allow any sort function to be considered a continuous or inter item function. This separates the notion that the two are related and brings TimingFunction to be an entirely new concept.