Skip to content

Conversation

@DABH
Copy link
Contributor

@DABH DABH commented Mar 24, 2019

"Fixes" cases such as the one here where users want simple to stringify objects. Fair enough, "simple" sounds like it should "just work" even if jsonStringify is an extra performance hit.

winstonjs/winston#1606

@DABH
Copy link
Contributor Author

DABH commented Mar 24, 2019

@indexzero this causes info.message to get quotes around it if it's a string, e.g.
'info: "whatever"' instead of 'info: whatever'
do you reckon that's ok? jsonStringify and util.inspect both do that, not sure if one can get around it without explicit typecheck/case for String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant