ignore transparent improvements #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikReider
reviewed
Jul 13, 2025
| tex_options.discard_transparent = true; | ||
| fx_render_pass_add_texture(pass, &tex_options); | ||
|
|
||
| fx_render_pass_add_discard_transparent(pass, &tex_options->base); |
Member
There was a problem hiding this comment.
Wouldn't it be better to just create a fx_render_pass_add_blur_texture or something which does what these lines + lines 959->969? Then we should be able to remove the stenciling right?
WillPower3309
commented
Nov 4, 2025
| struct blur_shader blur2; | ||
| struct blur_effects_shader blur_effects; | ||
| struct discard_transparent_shader discard_transparent_rgba; | ||
| struct discard_transparent_shader discard_transparent_rgbx; |
Member
Author
There was a problem hiding this comment.
RGBX shouldn't be needed, since it has no opacity
WillPower3309
commented
Nov 4, 2025
| void main() { | ||
| if (sample_texture().a == 0.0) { | ||
| discard; | ||
| return; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the discarding logic into a separate shader and fixed the rotation issue
Will close #132 and #108