20251229 Coverity Dereference before Null check #9591
Conversation
rlm2002
force-pushed
the
coverity
branch
2 times, most recently
from
145ce01 to
9f9f3b4
Compare
add new scope, whitespace
|
retest this please jenkins: Agent offline exception |
| if (P == NULL || modulus == NULL){ | ||
| return ECC_BAD_ARG_E; | ||
| } | ||
| { |
There was a problem hiding this comment.
The DECL_MP_INT_SIZE_DYN can be at top, this is just declaring, not allocating... that's done in NEW_MP_INT_SIZE. Then revert all the indent changes. Thanks
There was a problem hiding this comment.
I think it's reasonable to close this PR without merging then. The remaining changes wouldn't make a difference.
There was a problem hiding this comment.
I like the new argument NULL checking since this API can be built as public facing.
There was a problem hiding this comment.
Sorry, just remembered the logic for the change here. The current format moves DECL_MP_INT_SIZE_DYN below the already existing NULL check since mp_bitsused(modulus) is defined ((a)->used * SP_WORD_SIZE), which is what flagged the original Coverity issue. The additional scope and indent prevents C99 standard compilation issues.
3 participants
Description
CID 315897 Dereference before null check - move null check to prevent dereference before null check issue