Fix CRL Number hex string buffer overflow in CRL parser #9628
+205
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
retest this please |
padelsbach
reviewed
Jan 8, 2026
Contributor
padelsbach
left a comment
padelsbach
left a comment
There was a problem hiding this comment.
Good find. I added some minor questions and comments
SparkiDev
requested changes
Jan 8, 2026
Contributor
Author
|
retest this please |
padelsbach
reviewed
Jan 9, 2026
padelsbach
approved these changes
Jan 9, 2026
Contributor
Author
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
crlNumberfield in theCRL_Entrystructure stores the CRL Number as a hexadecimal string usingmp_toradix. However, its buffer size is defined byCRL_MAX_NUM_SZ, which represents the maximum CRL Number size in octets, not the hexadecimal string length.Since each octet requires two hexadecimal characters plus a null terminator, the hexadecimal string buffer size should be defined as
CRL_MAX_NUM_SZ * 2 + 1.Issue#9086
Testing
Add unit test
Checklist