Merged
Conversation
irfano
added
status: do not merge
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
irfano
changed the title
Collaborator
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
| WOO_POS_LOCAL_CATALOG_FILE_APPROACH("woo_pos_local_catalog_file_approach"), | ||
| WOO_PUSH_NOTIFICATIONS_SYSTEM("woo_push_notifications_system", default = false), | ||
| WOO_PUSH_NOTIFICATIONS_SYSTEM_M2("woo_push_notifications_system_m2", default = false), | ||
| WOO_SELF_DRIVEN_PUSH_NOTIFICATIONS_M1("woo_self_driven_push_notifications_m1", default = false), |
Contributor
There was a problem hiding this comment.
What about using the local feature flag value as default value when not being able to retrieve the remote FF? I thought that was the idea from what we discussed over Slack
Contributor
Author
There was a problem hiding this comment.
default = false does that. If you want to use true when the remote flag isn't available, just update the default value to true.
I added the feature in #15299
Note: If no remote value exists, the default is used.
JorgeMucientes
approved these changes
Feb 13, 2026
Contributor
JorgeMucientes
left a comment
JorgeMucientes
left a comment
There was a problem hiding this comment.
Changes look good @irfano 👍🏼
…to issue/WOOMOB-2099-add-remote-flags-for-woo-pn-project
…to issue/WOOMOB-2099-add-remote-flags-for-woo-pn-project
Collaborator
|
|
…to issue/WOOMOB-2099-add-remote-flags-for-woo-pn-project # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/notifications/push/ShouldShowEnablePushNotificationsUi.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/util/FeatureFlagRepositoryTest.kt
…to issue/WOOMOB-2099-add-remote-flags-for-woo-pn-project # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/notifications/push/ShouldShowEnablePushNotificationsUi.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/jetpack/benefits/JetpackBenefitsViewModel.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/jetpack/benefits/JetpackBenefitsViewModelTest.kt
Collaborator
|
Version |
Base automatically changed from
issue/WOOMOB-2129-improve-remote-local-feature-flag
to
trunk
March 30, 2026 10:17
irfano
removed
the
status: do not merge
irfano
deleted the
issue/WOOMOB-2099-add-remote-flags-for-woo-pn-project
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We added a feature flag to the backend with the key
woo_self_driven_push_notifications_m1. This PR renames our local flags and adds keys for the remote flags.Backend PR: 202198-ghe-Automattic/wpcom
The default value (
false) will be used until the backend returns a value forwoo_self_driven_push_notifications_m1.Test Steps
For now, it’s not testable because the remote flag PR hasn’t been merged on the backend yet.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.