Skip to content

Fix crash in RawBlockEditorSettingsService #24944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+8 −4
Open

Fix crash in RawBlockEditorSettingsService #24944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aea6df
Fix crash in RawBlockEditorSettingsService
kean Oct 14, 2025
f95cdd9
Merge branch 'trunk' into fix/crash-on-launch
kean Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
26.5
-----
* [*] Add "Access" section to "Post Settings" [#24942]
* [*] Fix rare crash on launch when new editor is enabled [#24944]

26.4
-----
Expand Down
2 changes: 1 addition & 1 deletion Sources/WordPressData/Swift/NSManagedObject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public extension NSManagedObject {
return result.flatMap({ ValueType(rawValue: $0) })
}

var locallyUniqueId: String {
var locallyUniqueID: String {
let data = Data(self.objectID.uriRepresentation().absoluteString.utf8)
return SHA256.hash(data: data).compactMap { String(format: "%02x", $0) }.joined()
}
Expand Down
9 changes: 6 additions & 3 deletions WordPress/Classes/Services/RawBlockEditorSettingsService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@ final class RawBlockEditorSettingsService {

private let blogID: String
private var refreshTask: Task<Data, Error>?
private let dotOrgRestAPI: WordPressOrgRestApi
private let dotOrgRestAPI: WordPressOrgRestApi?
private var prefetchTask: Task<Void, Never>?

@MainActor
init(blog: Blog) {
self.dotOrgRestAPI = WordPressOrgRestApi(blog: blog)!
self.blogID = blog.locallyUniqueId
self.dotOrgRestAPI = WordPressOrgRestApi(blog: blog)
self.blogID = blog.locallyUniqueID
}

private func fetchSettingsFromAPI() async throws -> Data {
guard let dotOrgRestAPI else {
throw URLError(.unknown)
}
let response: WordPressAPIResult<Data, WordPressOrgRestApiError> = await dotOrgRestAPI.get(
path: "/wp-block-editor/v1/settings"
)
Expand Down