Skip to content

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 17, 2025

Fixes https://linear.app/a8c/issue/CMM-809/button-done-disappears-when-you-enter-a-password-for-post. Closes https://linear.app/a8c/issue/CMM-556/add-status-field.

Changes

  • Replace PostVisibilityPicker with a new PostStatusView. It provides the same functionality, but improves the "enter password" flow and lets you submit the post to review if that's what you need.
  • Use a nicer icon for the “Publish” button in the context menu for posts

Note: I plan to improve the "Submit for Review" flow further in https://linear.app/a8c/issue/CMM-854/improve-submit-for-review-flow. It needs more and easy ways to move status.

Screenshots

Screenshot 2025-10-17 at 10 38 18 AM Screenshot 2025-10-17 at 10 38 22 AM

@kean kean added this to the 26.5 milestone Oct 17, 2025
@kean kean requested a review from crazytonyli October 17, 2025 15:04
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 17, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29561
VersionPR #24950
Bundle IDorg.wordpress.alpha
Commite77efde
Installation URL2mna7d3c8dm90
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 17, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29561
VersionPR #24950
Bundle IDcom.jetpack.alpha
Commite77efde
Installation URL4f4fgtok905eg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

)
} label: {
SettingsRow(Strings.status) {
SettingsRow(viewModel.context == .publishing ? Strings.statusAndVisibility : Strings.status) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostStatusView title is always "Status & Visibility", but why use a different text for the entrance in the list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess let's just call it "Status" like on the web. "Status" is a quintessential WordPress post thing. There is no such thing as "Visibility".

@kean kean force-pushed the task/fix-password-done-button-disappears-cmm-809 branch from a03041d to ec15957 Compare October 20, 2025 14:27
@kean kean requested a review from crazytonyli October 20, 2025 14:37
@sonarqubecloud
Copy link

@kean kean marked this pull request as draft October 21, 2025 16:07
@kean
Copy link
Contributor Author

kean commented Oct 22, 2025

I'm going to put it into "Draft" for now. Not completely sure it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants