-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Replace "Visibility" with "Status & Visibility" in the "Publishing" Sheet #24950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 29561 | |
Version | PR #24950 | |
Bundle ID | org.wordpress.alpha | |
Commit | e77efde | |
Installation URL | 2mna7d3c8dm90 |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 29561 | |
Version | PR #24950 | |
Bundle ID | com.jetpack.alpha | |
Commit | e77efde | |
Installation URL | 4f4fgtok905eg |
) | ||
} label: { | ||
SettingsRow(Strings.status) { | ||
SettingsRow(viewModel.context == .publishing ? Strings.statusAndVisibility : Strings.status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PostStatusView
title is always "Status & Visibility", but why use a different text for the entrance in the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess let's just call it "Status" like on the web. "Status" is a quintessential WordPress post thing. There is no such thing as "Visibility".
a03041d
to
ec15957
Compare
|
I'm going to put it into "Draft" for now. Not completely sure it's a good idea. |
Fixes https://linear.app/a8c/issue/CMM-809/button-done-disappears-when-you-enter-a-password-for-post. Closes https://linear.app/a8c/issue/CMM-556/add-status-field.
Changes
PostVisibilityPicker
with a newPostStatusView
. It provides the same functionality, but improves the "enter password" flow and lets you submit the post to review if that's what you need.Note: I plan to improve the "Submit for Review" flow further in https://linear.app/a8c/issue/CMM-854/improve-submit-for-review-flow. It needs more and easy ways to move status.
Screenshots