node(governor): Ignore configured tokens originating from ungoverned chains #4455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
approved these changes
Jul 31, 2025
Contributor
bruce-riley
left a comment
bruce-riley
left a comment
There was a problem hiding this comment.
Looks good to me (once tests pass).
johnsaigle
force-pushed
the
gov-exclude-deprecated-tokens
branch
from
bb3efb6 to
af2c2cd
Compare
johnsaigle
requested review from
SEJeff,
djb15,
mdulin2 and
pleasew8t
as code owners
Contributor
Author
|
Now that #4454 is merged, we need to wait for one token update cycle. It should clear out all of the tokens from deprecated chains automatically, which will let the unit tests added here pass. |
johnsaigle
force-pushed
the
gov-exclude-deprecated-tokens
branch
from
af2c2cd to
ddcd9d4
Compare
johnsaigle
force-pushed
the
gov-exclude-deprecated-tokens
branch
from
ddcd9d4 to
baefb9a
Compare
johnsaigle
force-pushed
the
gov-exclude-deprecated-tokens
branch
from
baefb9a to
9c2d245
Compare
mdulin2
approved these changes
Nov 20, 2025
…chains - Do not govern tokens from deprecated chains when initializing the governor - Do not include tokens from deprecated chains when generating mainnet tokens - Add unit test to ensure all configured tokens correspond to a governed chain. (we already enforce that all governed chains have governed tokens associated.)
johnsaigle
force-pushed
the
gov-exclude-deprecated-tokens
branch
from
9c2d245 to
23d5a18
Compare
djb15
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #4454. The new version of the script needs to be merged, run, and have its results committed first. Otherwise, the new unit tests will fail.