-
Notifications
You must be signed in to change notification settings - Fork 813
node: Remove references to deprecated chain Fantom #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
496bb68 to
de2c0f1
Compare
| return "avalanche" | ||
| case ChainIDAlgorand: | ||
| return "algorand" | ||
| case ChainIDFantom: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you manually modify these or regenerate them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember, but I just checked-out this PR, ran make go-generate from sdk/vaa/, and there was no change.
| 7 => Chain::Oasis, | ||
| 8 => Chain::Algorand, | ||
| 9 => Chain::Aurora, | ||
| 10 => Chain::Fantom, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking whether it makes sense to remove here or keep around considering the other obsolete chains from proto/publicrpc/v1/publicrpc.proto are still here? It might make sense to comment out here too?
4e6ed51 to
4c103bf
Compare
4c103bf to
f4f09a0
Compare
Fantom is deprecated and there are not enough Guardians running Fantom nodes to produce VAAs. As a result, we can remove references to it from the node and documentation. https://wormhole-foundation.github.io/wormhole-dashboard/#/?endpoint=Mainnet