Skip to content

Conversation

@kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Jul 24, 2025

Overview

When I tried pnpm test locally for #1806, I saw this error:

FAIL  src/__tests__/options.test.ts > Options > firefoxArgs > should log a warning when --remote-debugging-port is passed in
Error: Could not find "chrome" binary.

If it is installed in a custom location, you can specify the path with the browserPaths option.
 ❯ Module.resolveRunOptions src/options.ts:63:11

My /Applications folder contained Google Chrome.app instead of Chrome.app (it was installed via homebrew a while ago). Adding an alternative path to KNOWN_BROWSER_PATHS resolved the error. I also added the second path for Chrome Canary just in case.

Manual Testing

pnpm test stopped showing the above error.

Related Issue

NA

@netlify
Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit f9e95e0
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/688f5fa3b70c7f00089d0dd5
😎 Deploy Preview https://deploy-preview-1823--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kachkaev kachkaev changed the title test: Improve Chrome path search test: improve Chrome path search Jul 24, 2025
Copy link
Member

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for adding to the list!

@aklinker1
Copy link
Member

I fixed checks on main this morning, merged to get your PR passing.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 3, 2025

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1823

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1823

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1823

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1823

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1823

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1823

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1823

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1823

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1823

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1823

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1823

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1823

wxt

npm i https://pkg.pr.new/wxt@1823

commit: f9e95e0

@aklinker1 aklinker1 changed the title test: improve Chrome path search fix: improve Chrome path search Aug 3, 2025
@aklinker1 aklinker1 merged commit a2097e1 into wxt-dev:main Aug 3, 2025
16 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants