fix: improve Chrome path search #1823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When I tried
pnpm testlocally for #1806, I saw this error:My
/Applicationsfolder containedGoogle Chrome.appinstead ofChrome.app(it was installed viahomebrewa while ago). Adding an alternative path toKNOWN_BROWSER_PATHSresolved the error. I also added the second path for Chrome Canary just in case.Manual Testing
pnpm teststopped showing the above error.Related Issue
NA