Skip to content
This repository was archived by the owner on Dec 14, 2024. It is now read-only.

Add contests, register and unregister commands#66

Open
gnojus wants to merge 1 commit intoxalanq:masterfrom
gnojus:contests_and_registration
Open

Add contests, register and unregister commands#66
gnojus wants to merge 1 commit intoxalanq:masterfrom
gnojus:contests_and_registration

Conversation

@gnojus
Copy link
Contributor

@gnojus gnojus commented Feb 29, 2020

This PR adds ability to list upcoming contests, and register/unregister from them.

@xalanq
Copy link
Owner

xalanq commented Feb 29, 2020

Wow, awesome feature!

@xalanq
Copy link
Owner

xalanq commented Mar 1, 2020

Emm.. I found you have imported a new library goquery. Is it necessary ? Can regexp do the same works? I just don't want to import too many things..

@gnojus
Copy link
Contributor Author

gnojus commented Mar 1, 2020

goquery is also imported here:

"github.com/PuerkitoBio/goquery"
.
Everything can be done with standard libraries, the question is the how much code readability are we willing to sacrifice?
Though if you really want I could probably strip out goquery from this PR.

@xalanq
Copy link
Owner

xalanq commented Mar 1, 2020

goquery is also imported here:

"github.com/PuerkitoBio/goquery"

.
Everything can be done with standard libraries, the question is the how much code readability are we willing to sacrifice?
Though if you really want I could probably strip out goquery from this PR.

Hahahah. I forgot I used that lib too. OK, just use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants