-
Notifications
You must be signed in to change notification settings - Fork 722
Fixed componentWillReceiveProps warning #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please merge this, want to get rid of the warning message. |
|
Warning: componentWillReceiveProps is deprecated and will be removed in the next major version. Use static getDerivedStateFromProps instead. Please update the following components: DatePicker Learn more about this warning here: |
|
+1 to merge this PR |
|
Is it possible to make a new release including this merge request? Package hasn't received any release since April 2018 while there are a lot of open merge requests with good code. Maybe unpopular opinion: |
I really agree with you and I will be really grateful if I can do that or at least be a part of that |
|
This looks like a dead project without maintainer :( I think it is time to either:
|
|
@mieszko4 at our company we went to the react-native-community version as well. Way better maintained. |
did you do it? If yes, then please share the new npm-package. |
|
This looks like it might be a good and maintained alternative, that solves the same issue as this project originally did: wrapping the core ios and android datepicker components from react native in a nice crossplatform api: It is wrapping the extracted versions in https://github.com/react-native-community/datetimepicker/issues rather than the deprecated ones that ship with react native core that this library does. |
|
I made this package https://www.npmjs.com/package/react-native-datepicker-yaya only to solve the warning of the componentWillReceiveProps. Everyone is welcomed to use it instead of this package. |
|
PLEASE MERGE! |
Fixed
componentWillReceivePropswarningIssue #355