fixed issues with sf_bq236 and sf_bq320 #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, any updates on this issue? Please let me know if there's anything I need to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes issue #135
sf_bq236: Clarified ambiguous time period from "past 10 years" to "from 2014 to 2024 (11-year period)" to match the concrete date range used in the gold query. The original phrasing was problematic because "past 10 years" would produce different results depending on when the query is executed.
sf_bq320: Fixed incorrect count logic that was returning 214 instead of the expected 39. Changed from COUNT(*) to COUNT(DISTINCT "StudyInstanceUID") and corrected string matching from LIKE to exact equality (=). The original query was counting all records matching the StudyInstanceUID criteria rather than counting unique StudyInstanceUID values that meet the intersection conditions. This query has been tested in snowflake to verify accuracy as well.