Skip to content

Conversation

@manuelleduc
Copy link
Contributor

Jira URL

Changes

Description

Clarifications

  • Upgrade to Cristal 0.22.0
  • Cleanup a few dependencies that can now be removed (along with explicit css imports that are no longer needed)
  • Introduce a first minimal functional test
  • Introduce a mechanism to allow the save action to wait for the editor to perform some async tasks before saving

Screenshots & Video

N/A

Executed Tests

 mvn clean install -Pdocker,integration-tests -f xwiki-platform-core/xwiki-platform-blocknote -pl :xwiki-platform-blocknote-webjar,:xwiki-platform-blocknote-test-docker

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

@manuelleduc manuelleduc self-assigned this Oct 17, 2025
@manuelleduc manuelleduc requested a review from mflorea October 17, 2025 12:32
@socket-security
Copy link

socket-security bot commented Oct 17, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
npm/[email protected] has a Critical CVE.

CVE: GHSA-jf85-cpcp-j695 Prototype Pollution in lodash (CRITICAL)

Affected versions: < 4.17.12

Patched version: 4.17.12

From: xwiki-platform-core/xwiki-platform-bootstrap/src/main/package-lock.jsonnpm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
npm/[email protected] has a Critical CVE.

CVE: GHSA-jf85-cpcp-j695 Prototype Pollution in lodash (CRITICAL)

Affected versions: < 4.17.12

Patched version: 4.17.12

From: xwiki-platform-core/xwiki-platform-bootstrap/src/main/package-lock.jsonnpm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@manuelleduc manuelleduc changed the title XWIKI-23459: Upgrade to Cristal 0.22.0 XWIKI-23459: Upgrade to Cristal 0.23.1 Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants