Fix Action-Scheduler PHP 8.4 Deprecations - Bump PHP minimum to 7.1#1781
Open
Soean wants to merge 2 commits intoxwp:developfrom
Open
Fix Action-Scheduler PHP 8.4 Deprecations - Bump PHP minimum to 7.1#1781Soean wants to merge 2 commits intoxwp:developfrom
Soean wants to merge 2 commits intoxwp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP 8.4 I get a lot of deprecation messages like
PHP Deprecated: ActionScheduler_QueueCleaner::__construct(): Implicitly marking parameter $store as nullable is deprecated, the explicit nullable type must be used instead in /wp-content/plugins/stream/vendor/woocommerce/action-scheduler/classes/ActionScheduler_QueueCleaner.php on line 35It was fixed in Action-Scheduler 3.9.0: https://github.com/woocommerce/action-scheduler/releases/tag/3.9.0
Action-Scheduler 3.9.0 requires PHP 7.1.
Changes
This pull request updates the minimum required PHP version for the project from 7.0 to 7.1 and bumps the required version of the
woocommerce/action-schedulerdependency. These changes help ensure compatibility with newer PHP features and maintain dependency security.PHP version requirement updates:
composer.jsonand theWP_STREAM_MIN_PHP_VERSIONconstant instream.php. [1] [2]Requires PHP: 7.1header to the plugin filestream.phpfor clearer documentation and compatibility checks.Dependency updates:
woocommerce/action-schedulerfrom^3.8to^3.9incomposer.json.Checklist
contributing.md).Release Changelog